Ticket #7 (closed defect: fixed)

Opened 8 months ago

Last modified 5 months ago

DESTDIR incorrectly specified

Reported by: Paul Armstrong Assigned to: kmkaplan
Priority: minor Version:
Keywords: Cc:

Description (Last modified by kmkaplan)

aminstalldirs already has $(DESTDIR) in it so you don't need it in datastatedir = $(DESTDIR)$(localstatedir)/lib

The following patch fixes it: 

--- Makefile.in.old     Sun Dec 30 19:06:27 2007
+++ Makefile.in Sun Dec 30 19:06:37 2007
@@ -157,7 +157,7 @@
 top_builddir = @top_builddir@
 top_srcdir = @top_srcdir@
 AUTOMAKE_OPTIONS = foreign
-datastatedir = $(DESTDIR)$(localstatedir)/lib
+datastatedir = $(localstatedir)/lib
 greyfix_SOURCES = greyfix.c policy.c policy.h
 all: config.h
        $(MAKE) $(AM_MAKEFLAGS) all-am

Attachments

patch-makefile (382 bytes) - added by anonymous on 12/30/07 19:08:29.
patch for the Makefile (as inlining messed it up)
greyfix-7.patch (0.5 kB) - added by kmkaplan on 01/15/08 16:04:08.
Fix Ticket #7.

Change History

12/30/07 19:08:29 changed by anonymous

  • attachment patch-makefile added.

patch for the Makefile (as inlining messed it up)

12/31/07 09:22:29 changed by kmkaplan

  • owner set to kmkaplan.
  • status changed from new to assigned.
  • description changed.

The Makefile.in is actually generated from Makefile.am by automake. If you have automake please check that: 

--- old-greyfix/Makefile.am     2007-12-31 10:21:25.000000000 +0100
+++ new-greyfix/Makefile.am     2007-12-31 10:21:25.000000000 +0100
@@ -1,5 +1,5 @@
 AUTOMAKE_OPTIONS = foreign
-datastatedir = $(DESTDIR)$(localstatedir)/lib
+datastatedir = $(localstatedir)/lib
 sbin_PROGRAMS = greyfix
 greyfix_SOURCES = greyfix.c policy.c policy.h

corrects the defect.

Thank you for the report, Kim Minh.

01/15/08 16:04:08 changed by kmkaplan

  • attachment greyfix-7.patch added.

Fix Ticket #7.

01/15/08 16:04:31 changed by kmkaplan

  • status changed from assigned to closed.
  • resolution set to fixed.